Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix System.Double implementations for emulated floating point #1486

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Replace return value from false to not implemented exception.
  • Minor improvements in coding style.

Motivation and Context

  • Most calls were wrongly returning false when they should be returning not implemented exception.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

- Most calls were wrongly returning false when they should be returning not implemented exception.
- Minor improvements in coding style.
@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Nov 7, 2019
@nfbot
Copy link
Member

nfbot commented Nov 7, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 9e5c15f into develop Nov 7, 2019
@josesimoes josesimoes deleted the josesimoes-patch-1 branch November 7, 2019 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants