Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cast issues with socket addresses #1504

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Fix cast issues with socket addresses #1504

merged 1 commit into from
Nov 13, 2019

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 13, 2019 •
edited
Loading

Description

  • Rework casts of SOCK_sockaddr.
  • Rework code in IP addresses to use formal conversions and keeping the compiler happy.
  • Remove ADS_PACKED define from unsupported compiler.

Motivation and Context

  • In preparation for GNU gcc v9.
  • Improving code quality and readability.

How Has This Been Tested?

  • Tested with HTTP samples.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels Nov 13, 2019
@nfbot
Copy link
Member

nfbot commented Nov 13, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes requested a review from cw2 November 13, 2019 11:54
@josesimoes
Fix cast issues with socket addresses
2fc8052 
- Rework casts of SOCK_sockaddr in preparation for GNU gcc v9.
- Rework code in IP addresses to use formal conversions and keeping the compiler happy in preparation for GBU gcc v9.
- Remove ADS_PACKED define from unsupported compiler.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes removed the request for review from cw2 November 13, 2019 15:10
@josesimoes josesimoes merged commit 6b00fc6 into nanoframework:develop Nov 13, 2019
@josesimoes josesimoes deleted the fix-sockets-casts branch November 13, 2019 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot