Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change format of exception output #1506

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Change format of exception output #1506

merged 1 commit into from
Nov 14, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Replace hashes with plus signs in exception output message.

Motivation and Context

  • Prevents the copy/paste of the exception content to be wrongly mistaken with markdown formating.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Breaking-change labels Nov 13, 2019
@nfbot
Copy link
Member

nfbot commented Nov 13, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Change format of exception output
668ae3b 
Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the rework-exception-output branch from a15356d to 668ae3b Compare November 14, 2019 00:38
@josesimoes josesimoes closed this Nov 14, 2019
@josesimoes josesimoes deleted the rework-exception-output branch November 14, 2019 01:00
@josesimoes josesimoes merged commit 73389fa into nanoframework:develop Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot