Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract System.Text to a separate class lib #1507

Merged
merged 1 commit into from
Nov 14, 2019
Merged

Extract System.Text to a separate class lib #1507

merged 1 commit into from
Nov 14, 2019

Conversation

josesimoes
Copy link
Member

Description

  • Add System.Text class lib, CMakes, etc.
  • Add new build option for it.
  • Update CMake variants template accordingly.
  • Update mscorlib declaration and update CMake.
  • Enable System.Text build option for all targets.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Breaking-change labels Nov 14, 2019
@nfbot
Copy link
Member

nfbot commented Nov 14, 2019

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Extract System.Text to a separate class lib
7329256 
- Add System.Text class lib, CMakes, etc.
- Add new build option for it.
- Update cmake variants template accordingly.
- Update mscorlib declaration and update CMake.
- Enable System.Text build option for all targets.
- Update win32 test project.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit b433507 into nanoframework:develop Nov 14, 2019
@josesimoes josesimoes deleted the extract-system-text branch November 14, 2019 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Breaking-change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot