Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nxp Gpio update to use a standard interface and enable interrupts #1511

Merged
merged 13 commits into from
Nov 27, 2019
Merged

Nxp Gpio update to use a standard interface and enable interrupts #1511

merged 13 commits into from
Nov 27, 2019

Conversation

AdrianSoundy
Copy link
Member

Description

This is the changed low level GPIO driver for the NXP target.
Ported existing code to new layout and added the handling for interrupts.

How Has This Been Tested?

This hasn't been tested on a target board

Some methods for saving/finding/deleting gpio state information have been unit tested in a different environment so hopefully ok.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: adriansoundy adriansoundy@gmail.com

@nfbot
Copy link
Member

nfbot commented Nov 23, 2019

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: NXP i6 Everything related specifically with NXP targets Status: under review Type: enhancement labels Nov 25, 2019
josesimoes
josesimoes approved these changes Nov 25, 2019
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@MateuszKlatecki care to take a look please?

@MateuszKlatecki
Copy link
Member

In the Debug version, the outputs work. Input reading also works.
However, GpioPinValueChangedEvent is not triggered. From what I see it lacked configuration and enable interrupt for pins.
Unfortunately, in the optimized version, the program falls into HardFault right after starting.

@josesimoes
Copy link
Member

@MateuszKlatecki thank for testing this.

Any chance you can look into adding those missing configurations for the interrupts? 😁

The same goes for the hard fault. Considering that you're the only one with that board and that it's impossible to even start debugging that hard fault without actually running it on the hardware... 😉

@josesimoes
Copy link
Member

Are we OK with this?

@AdrianSoundy AdrianSoundy merged commit bf33916 into nanoframework:develop Nov 27, 2019
@josesimoes
Copy link
Member

@MateuszKlatecki waiting for your approval 😉

@AdrianSoundy
Copy link
Member Author

Yes ok now. Issue was GLobal_Lock fixed in PR #1518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

@MateuszKlatecki MateuszKlatecki Awaiting requested review from MateuszKlatecki

Assignees
No one assigned
Labels
Series: NXP i6 Everything related specifically with NXP targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AdrianSoundy @nfbot @MateuszKlatecki @josesimoes