Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential issue with flash write on STMF0 series #1521

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Fix potential issue with flash write on STMF0 series #1521

merged 2 commits into from
Dec 2, 2019

Conversation

antoniofagundes
Copy link
Member

@antoniofagundes antoniofagundes commented Dec 2, 2019 •
edited
Loading

Description

  • Add DSB to make sure we are writting the correct data on the flash write operations.
  • Remove unused code.

Motivation and Context

How Has This Been Tested?

  • Deploy Blinly sample with minsizerel build.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: António Fagundesantonio.fagundes@eclo.solutions

@nfbot
Copy link
Member

nfbot commented Dec 2, 2019

Hi @antoniofagundes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Platform: STM32 Everything related specifically with ChibiOS platform Type: bug labels Dec 2, 2019
@josesimoes josesimoes merged commit f022d68 into nanoframework:develop Dec 2, 2019
@josesimoes josesimoes deleted the antoniofagundes-patch-2 branch December 2, 2019 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Platform: STM32 Everything related specifically with ChibiOS platform Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error deploying to ST_NUCLEO64_F091RC
3 participants
@antoniofagundes @nfbot @josesimoes