Rework of UART on MIMXRT1060 #1529
Conversation
|
Hi @morali, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
josesimoes
added
Series: NXP i6
There was a problem hiding this comment.
Overall looks good! 👏
I can't test it so I'll default to your judgment on that.
Have to ask you to update the coding style to match the rest of the repo.
(we should have a linter to auto-format but we still don't have it, sorry)
Namelly:
- comments with // instead of /* */
- if clauses like this
if (condition)
{
}
else
{
}
| /* check if all requested bytes were written */ | ||
| if (bytesWritten != length) { | ||
| /* not sure if this is the best exception to throw here... */ | ||
| NANOCLR_SET_AND_LEAVE(CLR_E_FAIL); |
There was a problem hiding this comment.
This one is meant for a general CLR failure!! Too drastic to use here.
Maybe CLR_E_IO...
|
Thank you for your insight. |
I hear you! That's on the todo list for quite sometime... 😅 Would like to find a tool that could work both locally and could be launched as a GitHub check or even Azure Pipeline. Any suggestions? |
I hear you! That's on the todo list for quite sometime... 😅 Would like to find a tool that could work both locally and could be launched as a GitHub check or even Azure Pipeline. Any suggestions? |
It's cleanup of code and rework of some of the functions. I think that read and write is now more stable and it shouldn't drop any frames, like it with old implementation.
Description
Motivation and Context
More optimised code, less variables, use of static variables, checks for NULL pointers.
How Has This Been Tested?
Tested with SerialCommunication project from nanoFramework Samples.
I've tested read and write on LPUART3 port. I could receive and display strings on terminal properly.
Screenshots
Types of changes
Checklist:
Signed-off-by: morali jeremi.jasinski@gmail.com