-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of sdcard storage for NXP MIMXRT1060 port #1530
Conversation
Hi @morali, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: any reason for replacing the platform_malloc and free?
The correct way is to use the platform_NNNN calls.
d76238a
to
dbf229c
Compare
Yes, we are using different implementation of malloc on our device. |
I think there was some error with downloading some file. Could you rerun pipeline? |
@morali if you have a different implementation of malloc, that's OK. The platform_malloc (and free) are there for exactly that purpose: abstract whatever implementation there is for a plaform. You have to define those @ targets\FreeRTOS\common\platform_heap.c (which I think it's already there). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I don't have an NXP board to test so I'll default to your testing.
I've edited read/write binary and read/write text to open file in working thread. Which is a little bit faster and causes less stutter then previous implementation.
Also there was a problem when file write/read would end with error but the nanoCLR wouldn't get an event, which is also fixed.
Description
Motivation and Context
This bug caused big slowdown of application cycle while read or write was in progress.
How Has This Been Tested?
I've tested above fix with nanoFramework storage sample and with our own application. Storage read/write were successfull and without errors.
Screenshots
Types of changes
Checklist:
Signed-off-by: morali jeremi.jasinski@gmail.com