-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several fixes to 1-Wire on ESP32 #1553
Conversation
Modify Gpio UART TX mode to OPEN-DRAIN as per 1-wire specs.
Fix instability and loops when searching and more than two devices connected.
Hi @up-streamer, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please just remove the other 2 files besides the 1Wire controller one. They don't belong to this PR.
This file does not belong to PR nanoframework#1553
This file does not belong to PR nanoframework#1553
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed unecessary files for this PR
For some reason the CMakeSettings.json file is still showing… |
This reverts commit 8dbc19d.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
(I've reverted the changes in the cmake json file myself)
Thanks! |
Description
Motivation and Context
This is necessary to make 1-Wire bus work correctly on ESP32.
How Has This Been Tested?
It was tested by connecting three 18B20 sensors, In C#, looping to get the address and than looping to read each one temperature.
This also remove the need of a Open-drain or Open-Collector non inverter drive on UART TX output pin.
The 4.7k pull up resistor on 1-Wire bus is now mandatory as per 1-wire protocol.
Types of changes
Checklist:
Signed-off-by: Up-Streamer up_stream@hotmail.com