Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GetInteropNativeAssemblies #1556

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Fix GetInteropNativeAssemblies #1556

merged 1 commit into from
Feb 18, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Wrong check in the assemblies iteration.
  • Improve sanity checks.
  • Improve comments.

Motivation and Context

  • Was causing issues by addressing wrong memory.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: José Simões jose.simoes@eclo.solutions

@josesimoes
Fix GetInteropNativeAssemblies
e49b621 
- Wrong check in the assemblies iteration.

Signed-off-by: José Simões <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Feb 18, 2020
@nfbot
Copy link
Member

nfbot commented Feb 18, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 7e6c44f into nanoframework:develop Feb 18, 2020
@josesimoes josesimoes deleted the fix-dev-caps branch February 18, 2020 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot