Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hardware CRC32 module inclusion #1562

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Fix hardware CRC32 module inclusion #1562

merged 1 commit into from
Feb 24, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Move peripheral init to main() (booter and CLR) from CLR startup.

Motivation and Context

  • The hardware needs to be initialized before Receiver thread and type resolution need the CRC32 calculator.
  • The previous implementation was working because the CRC32 calculation on WP was disabled. Because WP now implements CRC32 has default it's required on both booter and CLR.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Fix hardware CRC32 module inclusion
0e0e3d8 
- Move CRC32 peripheral init to main (booter and CLR).

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Feb 24, 2020
@nfbot
Copy link
Member

nfbot commented Feb 24, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 3272c56 into nanoframework:develop Feb 24, 2020
@josesimoes josesimoes deleted the fix-crc32-stm32 branch February 24, 2020 18:12
josesimoes added a commit to Eclo/nf-Community-Targets that referenced this pull request Feb 24, 2020
@josesimoes
Include CRC32 init
cb008f5 
- Following nanoframework/nf-interpreter#1562.

***ALL***

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes mentioned this pull request Feb 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot