Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on interop assemblies struct and collection #1568

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Add new global with the count of interop assemblies.
  • Update template file accordingly.
  • Update CMake module to fill in the count.
  • Remove GetInteropNativeAssembliesCount from debugger as the code to get the count is now so simple that doesn't call for a function.
  • Rework GetInteropNativeAssemblies to use the new global.
  • Rework code to use the reply struct to return the assembly count because using the global directly was causing issues after GCC optimization.

Motivation and Context

  • General improvement as the interop assemblies array is now fixed at build and working on this basis calls for code improvements when using it.
  • The GCC optimizations when using MinRelSize was causing issues when using a variable to report back the number of assemblies. Reusing the reply structure now to do that has fixed the issue. The count is now returned as a uint32_t because it was previously handled in an uint32_t this requires updating the debugger code that handles this.

How Has This Been Tested?

  • Test app in debugger library.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

- Add new global with the count of interop assemblies.
- Update template file accordingly.
- Update CMake module to fill in the count.
- Remove GetInteropNativeAssembliesCount from debugger as the code to get the count is now so simple that doesn't call for a function.
- Rework GetInteropNativeAssemblies to use the new global.
- Rework code to use the reply struct to return the assembly count because using the global directly was causing issues after GCC optimization.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries Breaking-change labels Feb 27, 2020
@nfbot
Copy link
Member

nfbot commented Feb 27, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

josesimoes added a commit to Eclo/nf-debugger that referenced this pull request Feb 27, 2020
- Buffer now holds an UINT32.
- Following /nanoframework/nf-interpreter#1568.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit 68fc83c into nanoframework:develop Feb 27, 2020
@josesimoes josesimoes deleted the fix-device-caps-assemblies branch February 27, 2020 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Breaking-change Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants