Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Quail storage capability #1571

Merged
merged 8 commits into from
Mar 21, 2020
Merged

Add Quail storage capability #1571

merged 8 commits into from
Mar 21, 2020

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Mar 3, 2020 •
edited by josesimoes
Loading

This PR adds the necessary config for FatFS to the Quail target.

NOTE: this is untested (as I do not own the board) and SD Line detection is possibly set to the wrong pin.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Mar 3, 2020

Hi @networkfusion,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@networkfusion networkfusion added Series: STM32xx Everything related specifically with STM32 targets Status: under review Type: enhancement labels Mar 3, 2020
@josesimoes
Copy link
Member

No one from the community has reported any feedback on this so this is being merged.

@josesimoes josesimoes merged commit 5477cf3 into develop Mar 21, 2020
@josesimoes josesimoes deleted the develop-quail-storage branch March 21, 2020 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows.Storage not implemented in Quail firmware
3 participants
@networkfusion @nfbot @josesimoes