Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework CLR Debug class #1576

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Rework CLR Debug class #1576

merged 1 commit into from
Mar 5, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Replace CLR_DBG_Commands with the WireProtocol definitions.
  • Replace Monitor_ReadMemory, Monitor_WriteMemory, Monitor_CheckMemory and Monitor_EraseMemory with the WireProtocol definitions.
  • Drop scratch debugger and debugger messaging vars. These are now created/destroyed as needed.
  • Rework CreateInstance() and DeleteInstance() accordingly.
  • Improve AccessMemory function. Rework declaration and minor improvements in code.
  • Improvements in several functions like removing check of pointer to deployment storage.

Motivation and Context

  • Working towards a C only code base.
  • Simplification and code clean up from inherited code base.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels Mar 5, 2020
@nfbot
Copy link
Member

nfbot commented Mar 5, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes force-pushed the rework-CLR-debugger branch from 6c70bc4 to 2c4c2bc Compare March 5, 2020 19:32
@josesimoes
Rework CLR Debug class
4590032 
- Replace CLR_DBG_Commands with the WireProtocol definitions (working towards a C only code base).
- Replace Monitor_ReadMemory, Monitor_WriteMemory, Monitor_CheckMemory and Monitor_EraseMemory with the WireProtocol definitions (working towards a C only code base).
- Update code accordingly.
- Drop scratch debugger and debugger messaging vars. These are now created/destroyed as needed.
- Rework CreateInstance() and DeleteInstance() accordingly.
- Improve AccessMemory function. Rework declaration and minor improvements in code.
- Improvements in several functions like removing check of pointer to deployment storage.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the rework-CLR-debugger branch from 2c4c2bc to 4590032 Compare March 5, 2020 19:36
@josesimoes josesimoes merged commit ae88686 into nanoframework:develop Mar 5, 2020
@josesimoes josesimoes deleted the rework-CLR-debugger branch March 5, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot