Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable optimization on CRC32 calculation #1582

Merged
merged 1 commit into from
Mar 10, 2020
Merged

Disable optimization on CRC32 calculation #1582

merged 1 commit into from
Mar 10, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Add attribute to disable optimization on CRC32 calculation.

Motivation and Context

  • Optimization "Os" with GNU GCC 8.3 is breaking CRC32 calculation when computing for 1 element (4 bytes = uint32).

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Remove optimization on CRC32 driver
fc3f8de 
Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels Mar 10, 2020
@nfbot
Copy link
Member

nfbot commented Mar 10, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Remove optimization on CRC32 driver Disable optimization on CRC32 calculation Mar 10, 2020
@josesimoes josesimoes merged commit fb09ab3 into nanoframework:develop Mar 10, 2020
@josesimoes josesimoes deleted the remove-optimization-crc branch March 10, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot