Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deploying for NXP board #1592

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Fix deploying for NXP board #1592

merged 1 commit into from
Mar 25, 2020

Conversation

MateuszKlatecki
Copy link
Member

Description

Fix writing to flash if start address isn't equal to program page

Motivation and Context

Ability to deploy program with newest VS Extension

How Has This Been Tested?

With NXP Board

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Mateusz Klatecki mateusz.klatecki@gc5.pl

@nfbot
Copy link
Member

nfbot commented Mar 23, 2020

Hi @MateuszKlatecki,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Series: NXP i6 Everything related specifically with NXP targets Type: bug labels Mar 25, 2020
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josesimoes josesimoes merged commit 8ddfe62 into nanoframework:develop Mar 25, 2020
@MateuszKlatecki MateuszKlatecki deleted the fix/deploying branch June 22, 2020 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: NXP i6 Everything related specifically with NXP targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants