Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix attribute parser for attribute classes without constructor #1596

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Fix attribute parser for attribute classes without constructor #1596

merged 1 commit into from
Mar 27, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Add missing condition to skip processing after constructor.

Motivation and Context

How Has This Been Tested?

  • Code in issue.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Fix bug with attribute parser
37e5b20 
- Add missing condition to skip processing after constructor.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Mar 27, 2020
@nfbot
Copy link
Member

nfbot commented Mar 27, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit d9a8672 into nanoframework:develop Mar 27, 2020
@josesimoes josesimoes changed the title Fix bug with attribute parser Fix attribute parser for attribute classes without constructor Mar 27, 2020
@josesimoes josesimoes deleted the fix-587 branch March 27, 2020 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error getting attributes without parameters for field
2 participants
@josesimoes @nfbot