Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix STM32F769I clock settings #1600

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fix STM32F769I clock settings #1600

merged 1 commit into from
Apr 8, 2020

Conversation

piwi1263
Copy link
Member

@piwi1263 piwi1263 commented Apr 7, 2020

Description

Updated clock settings in mcuconf.h

Motivation and Context

  • Fixes issue reported by Songwei.Fu on Discord community channel targets-stm32.

How Has This Been Tested?

Local build and deploy to device, running VS and used F5 to deploy and debug application.

Screenshots

image

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: piwi1263 piwi1263@gmail.com

@piwi1263
update clock settings
7902a4c 
Updated clock settings in mcuconf.h

Signed-off-by: piwi1263 <piwi1263@gmail.com>
@nfbot
Copy link
Member

nfbot commented Apr 7, 2020

Hi @piwi1263,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@piwi1263 piwi1263 requested a review from josesimoes April 7, 2020 18:30
josesimoes
josesimoes approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

(haven't actually tested it on hardware)

@josesimoes josesimoes added Series: STM32xx Everything related specifically with STM32 targets Type: bug labels Apr 8, 2020
@josesimoes josesimoes changed the title update clock settings Fix STM32F769I clock settings Apr 8, 2020
@josesimoes
Copy link
Member

One question before merging: shouldn't these changes be also on nanoBooter?

@piwi1263
Copy link
Member Author

piwi1263 commented Apr 8, 2020 •
edited
Loading

@josesimoes that’s the strange thing the were/are already in nanoBooter.

@josesimoes josesimoes merged commit c9010d3 into nanoframework:develop Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes approved these changes

Assignees
No one assigned
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piwi1263 @nfbot @josesimoes