Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IL instruction isinst #1614

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Fix IL instruction isinst #1614

merged 1 commit into from
Apr 27, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Rework CastToType function and IsInstanceOf to properly handle IL instruction IL isinst which wasn't dealing properly with the workflow when casting requested by ISINST instruction.

Motivation and Context

How Has This Been Tested?

  • Sample app in the issue. The output is now the expected one.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes
Fix IL instruction isinst
929b0b7 
Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes added Type: bug Area: Interpreter Everything related with the interpreter, execution engine and such labels Apr 27, 2020
@nfbot
Copy link
Member

nfbot commented Apr 27, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit a27e35f into nanoframework:develop Apr 27, 2020
@josesimoes josesimoes deleted the fix-484 branch April 27, 2020 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid type after assigning an array to the object
2 participants
@josesimoes @nfbot