Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work GpioChangeCounter #1616

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Work GpioChangeCounter #1616

merged 1 commit into from
Apr 28, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Update Devices.Gpio assembly declaration.
  • Rework NativeRead in ESP32 to return ChangeCount object instead of partial value.
  • Fix conversion from ms to .NET ticks.
  • Update stubs on all targets.

Motivation and Context

How Has This Been Tested?

  • Smoke test from code in the issue above.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: bug Area: Common libs Everything related with common libraries labels Apr 28, 2020
@nfbot
Copy link
Member

nfbot commented Apr 28, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes
Work GpioChangeCounter
ee60261 
- Update Devices.Gpio assembly declaration.
- Rework NativeRead in ESP32 to return ChangeCount object instead of partial value.
- Fix conversion from ms to .NET ticks.
- Update stubs on all targets.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes force-pushed the update-gpio-assembly branch from e38c745 to ee60261 Compare April 28, 2020 18:52
@josesimoes josesimoes merged commit 6bd3615 into nanoframework:develop Apr 28, 2020
@josesimoes josesimoes deleted the update-gpio-assembly branch April 28, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot