Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on DateTime code #1629

Merged
merged 1 commit into from
May 8, 2020
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Remove NewObject function. New DateTime objects are now created using type descriptors.
  • Add UTC and ticks mask to properly set/clear tick values.
  • Improve checks on all parameters in DateTime constructor.
  • Replace individual calls to get DateTime members with a single function that receives a parameter requesting the date part.
  • Update mscorlib assembly declaration.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

@josesimoes josesimoes added Type: enhancement Area: Common libs Everything related with common libraries labels May 8, 2020
@nfbot
Copy link
Member

nfbot commented May 8, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

- Remove NewObject function. New DateTime objects are now created using type descriptors.
- Add UTC and ticks mask to properly set/clear tick values.
- Improve checks on all parameters in DateTime constructor.
- Replace individual calls to get DateTime members with a single function that receives a parameter requesting the date part.
- Update mscorlib assembly declaration.

Signed-off-by: josesimoes <jose.simoes@eclo.solutions>
@josesimoes josesimoes merged commit a21dfe3 into nanoframework:develop May 8, 2020
@josesimoes josesimoes deleted the work-datetime branch May 8, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants