Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework NativeInit for SPI #1646

Merged
merged 2 commits into from
May 27, 2020
Merged

Rework NativeInit for SPI #1646

merged 2 commits into from
May 27, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Reorganize code in NativeInit.
  • Remove casts from calls to ComputeBaudRate.

Motivation and Context

  • Resolves issues with debug session restarting for STM32 targets using SPI.
  • For some reason the build in MinSizeRel (most likely optimizations) was causing issues with the code on this function.

How Has This Been Tested?

  • SPI sample. Now either connected or disconnected from VS the target boots properly.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: josesimoes jose.simoes@eclo.solutions

- Reorganize code in NativeInit.
- Remove casts from calls to ComputeBaudRate.
@josesimoes josesimoes added Type: bug Series: STM32xx Everything related specifically with STM32 targets labels May 27, 2020
@nfbot
Copy link
Member

nfbot commented May 27, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 970f4ba into develop May 27, 2020
@josesimoes josesimoes deleted the fix-stm32-spi branch May 27, 2020 02:27
@josesimoes
Copy link
Member Author

ping @KiwiBryn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: STM32xx Everything related specifically with STM32 targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants