Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ESP32 serial update #1658

Merged
merged 5 commits into from
Jun 23, 2020
Merged

Rework ESP32 serial update #1658

merged 5 commits into from
Jun 23, 2020

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Jun 14, 2020

Description

  • Rework of ESP32 serial.
  • Fixes problem with IDF 3.3.1 not firing events for RX.

Motivation and Context

How Has This Been Tested?

Simple test program. With read/write only and events

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Jun 14, 2020

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nanoframework nanoframework deleted a comment from nfbot Jun 14, 2020
@nanoframework nanoframework deleted a comment from nfbot Jun 14, 2020
@AdrianSoundy AdrianSoundy changed the title Rework serial Rework ESP32 serial update Jun 15, 2020
@josesimoes josesimoes closed this Jun 15, 2020
@josesimoes josesimoes force-pushed the develop-rework-esp32-serial branch from 3721e8e to b7023a7 Compare June 15, 2020 13:15
@josesimoes josesimoes reopened this Jun 15, 2020
@josesimoes
Copy link
Member

Hi @MikeRogers0,

Despite having add the words to the ignore collection, I'm still seeing them reported as errors...
I'm refering to the "Uart" word in the annotation on this PR. Not sure if it needs to be added in all possible variations, which would be "Uart", "uart" and "UART"...

PS: btw, thank you so much for this great tool! 👏 😃

@nanoframework nanoframework deleted a comment from github-actions bot Jun 22, 2020
@MikeRogers0
Copy link

MikeRogers0 commented Jun 22, 2020

@josesimoes Looking into this now :)

Despite having add the words to the ignore collection

https://github.com/nanoframework/nf-interpreter - When I look in here, I'm not seeing a .typo-ci.yml file :/ Is it in another branch PR?

@josesimoes
Copy link
Member

josesimoes commented Jun 22, 2020

@josesimoes Looking into this now :)

Despite having add the words to the ignore collection

https://github.com/nanoframework/nf-interpreter - When I look in here, I'm not seeing a .typo-ci.yml file :/ Is it in another branch PR?
@MikeRogers0 It's on the organization .github repo. I thought it was allowed to put it there... maybe I'm mistaken...

@MikeRogers0
Copy link

@josesimoes My apologies, right now it only looks in the matching repository.

I've added supporting .github repositories as a fallback to my TODO list! That would be pretty awesome!

@josesimoes
Copy link
Member

@MikeRogers0 undestood.
Yes, that would be awesome for organizations that have a bunch of repos, like this one! 😉
Thanks.

@nfbot
Copy link
Member

nfbot commented Jun 23, 2020

There where issues with the code style on the source files.
A PR was submitted with the code style fixes. See https://api.github.com/repos/nanoframework/nf-interpreter/pulls/1666.

@nanoframework nanoframework deleted a comment from github-actions bot Jun 23, 2020
@josesimoes josesimoes merged commit 3c1b662 into develop Jun 23, 2020
@josesimoes josesimoes deleted the develop-rework-esp32-serial branch June 23, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serial Store and Write not working as expected SerialData.Chars event doesn't work properly
4 participants