Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GPIO events for ESP32 #1660

Merged
merged 1 commit into from
Jun 20, 2020
Merged

Improve GPIO events for ESP32 #1660

merged 1 commit into from
Jun 20, 2020

Conversation

AdrianSoundy
Copy link
Member

Description

Improves the ESP32 events so that it always toggles between high, low and doesn't fire more than 1 event of same level. This only happened when no de bounce was used.

Another fix was added to not allow a debounceTimeout of less than 10ms as this can cause an internal exception when it tries to create a Freertos timer of 0 ticks

Motivation and Context

The main problem for this issue 630 is a combination of not using debounceTimeout and a previous fix that stopped the input Pull up drive mode working.

How Has This Been Tested?`

Tested with modified version of sample program with simple reads of value and gpio events.
Checked drive mode pull up working.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Jun 20, 2020

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@AdrianSoundy AdrianSoundy merged commit 5f0bea5 into nanoframework:develop Jun 20, 2020
@AdrianSoundy AdrianSoundy deleted the gpio-test branch June 20, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESP32 - Gpio repeated behaviour
2 participants