Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code for SPI NativeInit #1676

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Add null to SPI handler.
  • Remove unnecessary break after goto.

Motivation and Context

  • Address compiler warning about possible use of uninitialized variable.
  • Remove potential issue with linker optimizations.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Add null to SPI handler.
- Remove unnecessary break after goto.
@nfbot
Copy link
Member

nfbot commented Jul 8, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot
Copy link
Member

nfbot commented Jul 8, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#14.

Make sure you are using the project code style. Check the details here.

Automated fixes for code style.
@josesimoes josesimoes merged commit c744762 into nanoframework:develop Jul 8, 2020
@josesimoes josesimoes deleted the fix-spi-init branch July 8, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants