Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes in install scripts #1681

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Correct function call in install vs code.
  • Add missing required parameter in Install-Module.
  • Remove "wrong" path for location of local mbedtls source.

(thanks to @bauland and @wjax for the heads up and testing)

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Correct function call in install vs code.
- Add missing required parameter in Install-Module.
- Remove "wrong" path for location of local mbedtls source.
@nfbot
Copy link
Member

nfbot commented Jul 14, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes merged commit 0485188 into nanoframework:develop Jul 14, 2020
@josesimoes josesimoes deleted the fixes-install-scripts branch July 14, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants