-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ESP32 Serial Native-store hang fix #1683
ESP32 Serial Native-store hang fix #1683
Conversation
Hi @AdrianSoundy, I'm nanoFramework bot. A human will be reviewing it shortly. 😉 |
Hi @AdrianSoundy, 😞 If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context' |
@AdrianSoundy there are issues with the code style on the source files. Make sure you are using the project code style. Check the details here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for taking care of this.
Please merge the PR with the code style fixes and this is good to go.
Automated fixes for code style.
@AdrianSoundy there are issues with the code style on the source files. Make sure you are using the project code style. Check the details here. |
…b16-cbbf-43f2-8aae-4918698bd399 Code style fixes for nanoframework/nf-interpreter PR#1683
Description
Fixes a problem with LongRunning operations
When using LongRunning it would hang in the Native-store method due to the LongRunning variable not being true the next time around as the buffer length was now shorter due to characters being sent.
Now stores LongRunning bool in NF_PAL_UART structure which is only initialized first time through.
Fix an issue where the pin assignment were reset when COM port closed and reopened
Fix a config problem if Xon/Xoff is used.
Motivation and Context
How Has This Been Tested?
Tested with my current project which failed straight away with serial at 9600 and longer strings.
There may still be a issue in this area as i did have a stop after running for a while but it also may be unrelated. I will be doing further testing. This PR fixes main problem.
Types of changes
Checklist: