Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 Serial Native-store hang fix #1683

Merged
merged 3 commits into from
Jul 25, 2020
Merged

ESP32 Serial Native-store hang fix #1683

merged 3 commits into from
Jul 25, 2020

Conversation

AdrianSoundy
Copy link
Member

@AdrianSoundy AdrianSoundy commented Jul 18, 2020

Description

  • Fixes a problem with LongRunning operations
    When using LongRunning it would hang in the Native-store method due to the LongRunning variable not being true the next time around as the buffer length was now shorter due to characters being sent.
    Now stores LongRunning bool in NF_PAL_UART structure which is only initialized first time through.

  • Fix an issue where the pin assignment were reset when COM port closed and reopened

  • Fix a config problem if Xon/Xoff is used.

Motivation and Context

How Has This Been Tested?

Tested with my current project which failed straight away with serial at 9600 and longer strings.

There may still be a issue in this area as i did have a stop after running for a while but it also may be unrelated. I will be doing further testing. This PR fixes main problem.

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Jul 18, 2020

Hi @AdrianSoundy,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot
Copy link
Member

nfbot commented Jul 18, 2020

Hi @AdrianSoundy,

😞 If this PR does address any issue, you have to remove the content Fixes/Closes/Resolves(...) under 'Motivation and Context'

@nfbot
Copy link
Member

nfbot commented Jul 18, 2020

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See AdrianSoundy#3.

Make sure you are using the project code style. Check the details here.

@AdrianSoundy AdrianSoundy added Series: ESP32 Everything related specifically with ESP32 series targets Status: under review labels Jul 18, 2020
@AdrianSoundy AdrianSoundy requested a review from josesimoes July 18, 2020 10:55
nfbot
nfbot approved these changes Jul 19, 2020
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for taking care of this.

Please merge the PR with the code style fixes and this is good to go.

Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Jul 25, 2020

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See AdrianSoundy#4.

Make sure you are using the project code style. Check the details here.

…b16-cbbf-43f2-8aae-4918698bd399

Code style fixes for nanoframework/nf-interpreter PR#1683
@AdrianSoundy AdrianSoundy merged commit cd986ae into nanoframework:develop Jul 25, 2020
@AdrianSoundy AdrianSoundy deleted the serial-store-hang branch July 25, 2020 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Series: ESP32 Everything related specifically with ESP32 series targets Status: under review Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants