Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework CPU GPIO for TI SimpleLink #1692

Merged
merged 2 commits into from
Sep 3, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Replace GPIO pin number with index.
  • Move GPIO declarations from sysconfig generated files to array.
  • Replace array with linked list for input pins.
  • Update sysconfig project file to remove GPIO declarations and GPIO drivers.

Motivation and Context

  • TI SimpleLink driver uses a fixed array with GPIO declarations and the API uses the index of that array as parameter instead of the GPIO pin number. This is completely different of the "standard" implementation of the CPU GPIO layer. Had to rework almost the layer for the TI to make it work this way.

How Has This Been Tested?

  • Blinky sample.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Replace GPIO pin number with index.
- Move GPIO declarations from sysconfig generated files to array.
- Replace array with linked list for input pins.
- Update sysconfig project file to remove GPIO declarations and GPIO drivers.
@nfbot
Copy link
Member

nfbot commented Sep 3, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot nfbot added the Type: bug label Sep 3, 2020
@nfbot
Copy link
Member

nfbot commented Sep 3, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#25.

Make sure you are using the project code style. Check the details here.

Automated fixes for code style.
@josesimoes josesimoes merged commit b8ace0f into nanoframework:develop Sep 3, 2020
@josesimoes josesimoes deleted the fix-ti-cpu-gpio branch September 3, 2020 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants