Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add class library System.IO.FileSystem #1705

Merged
merged 24 commits into from
Dec 11, 2020
Merged

Add class library System.IO.FileSystem #1705

merged 24 commits into from
Dec 11, 2020

Conversation

NiciAndres
Copy link
Contributor

@NiciAndres NiciAndres commented Sep 28, 2020 •
edited by josesimoes
Loading

Description

Add new System.IO.FileSystem Library

Motivation and Context

Make this library implemented by us available for everyone on nF.

How Has This Been Tested?

It was tested in our intern project. Not yet tested as system library, because WIP

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes marked this pull request as draft September 30, 2020 10:38
@josesimoes josesimoes added Area: Common libs Everything related with common libraries Status: in progress labels Sep 30, 2020
@josesimoes josesimoes changed the title WIP - System Library System.IO.FileSystem Add class library System.IO.FileSystem Sep 30, 2020
@josesimoes josesimoes force-pushed the develop branch 3 times, most recently from 3734a91 to 2c0061f Compare October 19, 2020 14:19
@piwi1263
Copy link
Member

Hi Nicholas, can it be that for the ORGPAL_THREE board you overlooked someting ?

image

@josesimoes
Copy link
Member

@NiciAndres the CMake that you have is missing some entries for the path hints.
You really have to update you VS extension to have this fixed, along with other formatting bits that have been corrected there...

josesimoes
josesimoes reviewed Nov 2, 2020
View reviewed changes
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the copyright headers need to be changed to match the latest version in use.

CMakeLists.txt Outdated Show resolved Hide resolved
targets/CMSIS-OS/ChibiOS/ORGPAL_PALTHREE/cmake-variants.json Outdated Show resolved Hide resolved
@NiciAndres NiciAndres force-pushed the Lib_System_IO_FileSystem branch from ff9c753 to 631002a Compare November 19, 2020 16:26
@NiciAndres NiciAndres force-pushed the Lib_System_IO_FileSystem branch from a269fff to dfbeab4 Compare December 3, 2020 20:08
@NiciAndres NiciAndres force-pushed the Lib_System_IO_FileSystem branch from 28366d7 to 83e8d42 Compare December 10, 2020 13:34
@NiciAndres NiciAndres marked this pull request as ready for review December 10, 2020 13:56
@josesimoes
Work CI-CD
41afb73 
- Remove inclusion of API_Windows.Storage in build options, these are controlled by the SDCARD and USBMSD options.
- Enable back SDCARD option for ESP32 targets.
- Add check for ESP32 build to remove inclusion of API_System.IO.FileSystem API because of lack of supporting configuration in FATFS. See nanoframework/Home#668.
@josesimoes josesimoes force-pushed the Lib_System_IO_FileSystem branch from 1cab1f7 to 41afb73 Compare December 11, 2020 07:35
@nanoframework nanoframework deleted a comment from nfbot Dec 11, 2020
@nanoframework nanoframework deleted a comment from nfbot Dec 11, 2020
@nanoframework nanoframework deleted a comment from nfbot Dec 11, 2020
@nanoframework nanoframework deleted a comment from nfbot Dec 11, 2020
@nanoframework nanoframework deleted a comment from nfbot Dec 11, 2020
@nanoframework nanoframework deleted a comment from nfbot Dec 11, 2020
@nanoframework nanoframework deleted a comment from nfbot Dec 11, 2020
@josesimoes josesimoes merged commit 9110c28 into nanoframework:develop Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josesimoes josesimoes josesimoes left review comments

Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries hacktoberfest-accepted Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NiciAndres @piwi1263 @josesimoes @nfbot