Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework system state and PAL events #1710

Merged
merged 3 commits into from
Oct 2, 2020

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Oct 2, 2020

Description

  • Replace GLOBAL LOCK & UNLOCK with built-in atomic operations.
  • Move SystemEvents from platform to global implementation.
  • Move PAL Events from platform to global implementation.
  • Split PAL Events to allow platform specific implementation.

Motivation and Context

  • Improved performance by using the compiler built-in atomic operation instead of doing it the hard way with expensive operations.
  • Following DRY: SystemEvents implementation was repeated on all platform.
  • Following DRY: PAL Events implementation was mostly repeated on all platforms.

How Has This Been Tested?

  • Several samples.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Replace GLOBAL LOCK & UNLOCK with builtin atomic operations.
- Move SystemEvents from platform to global implemention.
@nfbot
Copy link
Member

nfbot commented Oct 2, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Area: Interpreter Everything related with the interpreter, execution engine and such hacktoberfest-accepted labels Oct 2, 2020
@nfbot
Copy link
Member

nfbot commented Oct 2, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#38.

Make sure you are using the project code style. Check the details here.

nfbot and others added 2 commits October 2, 2020 13:40
@josesimoes josesimoes merged commit 7b89fcf into nanoframework:develop Oct 2, 2020
@josesimoes josesimoes deleted the improve-system-locks branch October 2, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Area: Interpreter Everything related with the interpreter, execution engine and such hacktoberfest-accepted Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants