Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring DAC native layer inline with managed #1718

Merged
merged 7 commits into from
Oct 3, 2020
Merged

Bring DAC native layer inline with managed #1718

merged 7 commits into from
Oct 3, 2020

Conversation

networkfusion
Copy link
Member

Description

May require update to checksum

Motivation and Context

Brings native layer inline with managed lib changes

How Has This Been Tested?

TBD

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

May require update to checksum
@nfbot
Copy link
Member

nfbot commented Oct 2, 2020

Hi @networkfusion,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot
Copy link
Member

nfbot commented Oct 2, 2020

@networkfusion there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See networkfusion#3.

Make sure you are using the project code style. Check the details here.

@nfbot
Copy link
Member

nfbot commented Oct 2, 2020

@networkfusion there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See networkfusion#5.

Make sure you are using the project code style. Check the details here.

Automated fixes for code style.
@networkfusion networkfusion marked this pull request as ready for review October 3, 2020 00:56
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josesimoes josesimoes added Area: Common libs Everything related with common libraries hacktoberfest-accepted labels Oct 3, 2020
@josesimoes josesimoes merged commit a9c118d into nanoframework:develop Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants