Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result check on local variables initialization #1740

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Add result check when calling locals initialization function.

Motivation and Context

  • Without it the initialization of local vars could failed unnoticed causing issues ahead.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Without it the initialization of local vars could failed unnoticed causing issues ahead.
@nfbot
Copy link
Member

nfbot commented Oct 21, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes changed the title Add result check on locals initialization Add result check on local variables initialization Oct 21, 2020
@josesimoes josesimoes added Area: Interpreter Everything related with the interpreter, execution engine and such hacktoberfest-accepted labels Oct 21, 2020
@nfbot
Copy link
Member

nfbot commented Oct 21, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#46.

Make sure you are using the project code style. Check the details here.

Automated fixes for code style.
@josesimoes josesimoes merged commit a4124cb into nanoframework:develop Oct 21, 2020
@josesimoes josesimoes deleted the improve-check-locals-init branch October 21, 2020 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Interpreter Everything related with the interpreter, execution engine and such hacktoberfest-accepted Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants