Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and rework System.Device.Gpio #1742

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Update and rework System.Device.Gpio #1742

merged 2 commits into from
Oct 22, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Extract code for SetNative, Read and Write code in Gpio to allow reuse.
  • Rework code in Gpio class to use these new members.
  • Rework code in GpioController to use the new Gpio members.
  • Update assembly declaration.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes
Update and rework System.Device.Gpio
7656d1c 
- Extract SetNative, Read and Write code in Gpio.
- Rework code in Gpio class to use these new members.
- Rework code in GpioController to use the new Gpio members.
- Update assembly declaration.
@nfbot
Copy link
Member

nfbot commented Oct 22, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@nfbot nfbot added Type: enhancement Type: dependencies Pull requests that update a dependency file(s) or version labels Oct 22, 2020
@nfbot
Copy link
Member

nfbot commented Oct 22, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#47.

Make sure you are using the project code style. Check the details here.

@nfbot
Code style fixes (#47)
a06cc97 
Automated fixes for code style.
@josesimoes josesimoes merged commit fcec675 into nanoframework:develop Oct 22, 2020
@josesimoes josesimoes deleted the improvements-sys-device-gpio branch October 22, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: dependencies Pull requests that update a dependency file(s) or version Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception when accessing writing to Gpio with System.Device.Gpio
2 participants
@josesimoes @nfbot