Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gpio.Write #1745

Merged
merged 1 commit into from
Oct 23, 2020
Merged

Fix Gpio.Write #1745

merged 1 commit into from
Oct 23, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Wasn't accessing correctly the value field on PinValue class.
  • Rework CPU GPIO Write to update gpio state store on write.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Wasn't accessing correctly the value field on PinValue class.
- Rework CPU GPIO Write to update gpio state store on write.
@nfbot
Copy link
Member

nfbot commented Oct 23, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Series: ESP32 Everything related specifically with ESP32 series targets labels Oct 23, 2020
@josesimoes josesimoes merged commit da806cf into nanoframework:develop Oct 23, 2020
@josesimoes josesimoes deleted the fix-gpio-write branch October 23, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Series: ESP32 Everything related specifically with ESP32 series targets Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants