Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on capability flags #1759

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Nov 6, 2020

Description

  • Add implementation of new capability flags in CLR and booter for all targets that implement it.
  • Rename fields in ping reply and command.
  • Remove flags from CLR_DBG_Commands.
  • Move some implementation to targets.
  • Provide weak implementations for most capabilities.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Nov 6, 2020

Hi @josesimoes,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Area: Targets labels Nov 6, 2020
@josesimoes josesimoes force-pushed the work-flags branch 2 times, most recently from 0a12ff2 to dd65d45 Compare November 6, 2020 18:07
@nfbot
Copy link
Member

nfbot commented Nov 6, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#54.

Make sure you are using the project code style. Check the details here.

@josesimoes josesimoes force-pushed the work-flags branch 4 times, most recently from 0eab490 to 87b3533 Compare November 6, 2020 19:15
- Add implementation of new capability flags in CLR and booter for all targets that implement it.
- Rename fields in ping reply and command.
- Remove flags from CLR_DBG_Commands.
- Move some implementation to targets.
- Provide weak implementations for most capabilities.
- Following nanoframework/nf-debugger#253.
@josesimoes josesimoes merged commit 5fa38ee into nanoframework:develop Nov 6, 2020
@josesimoes josesimoes deleted the work-flags branch November 9, 2020 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants