Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flash driver structure #1784

Merged
merged 3 commits into from
Nov 19, 2020
Merged

Rename flash driver structure #1784

merged 3 commits into from
Nov 19, 2020

Conversation

piwi1263
Copy link
Member

Description

Renamed SMT32FlashDriver to STM32FlashDriver in nf-overlay.

Motivation and Context

Structure name to follow naming of underlaying low level drivers.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: piwi1263 piwi1263@gmail.com

- renamed SMTFlashDriver in nf-overlay.

Signed-off-by: piwi1263 <piwi1263@gmail.com>
@nfbot
Copy link
Member

nfbot commented Nov 19, 2020

Hi @piwi1263,

I'm nanoFramework bot.
Thank you for your contribution!

A human will be reviewing it shortly. 😉

@piwi1263 piwi1263 requested a review from josesimoes November 19, 2020 19:24
@piwi1263 piwi1263 self-assigned this Nov 19, 2020
Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Nov 19, 2020

@piwi1263 there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See https://github.com/piwi1263/nf-interpreter/pull/2.

Make sure you are using the project code style. Check the details here.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! 🤝

@josesimoes josesimoes added the Platform: STM32 Everything related specifically with ChibiOS platform label Nov 19, 2020
…677-f15f-4360-9738-5c4c2324be5d

Code style fixes for nanoframework/nf-interpreter PR#1784
@piwi1263 piwi1263 merged commit c5582bd into nanoframework:develop Nov 19, 2020
@piwi1263 piwi1263 deleted the rework-flash-driver branch November 19, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: STM32 Everything related specifically with ChibiOS platform Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants