Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework WP commands #1791

Merged
merged 1 commit into from
Nov 24, 2020
Merged

Rework WP commands #1791

merged 1 commit into from
Nov 24, 2020

Conversation

josesimoes
Copy link
Member

Description

  • Move Monitor_ReadMemory, Monitor_WriteMemory, Monitor_EraseMemory, Monitor_QueryConfiguration, Monitor_QueryConfiguration, Monitor_UpdateConfiguration, Monitor_CheckMemory, Monitor_MemoryMap, and Monitor_FlashSectorMap implementations to a common location.
  • Remove unnecessary flags check on several commands.
  • Remove weak attribute on several WP commands implementation.

Motivation and Context

  • Remove duplicated code.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes added Platform: STM32 Everything related specifically with ChibiOS platform Area: Common libs Everything related with common libraries Platform: NXP Everything related specifically with FreeRTOS labels Nov 24, 2020
@nfbot
Copy link
Member

nfbot commented Nov 24, 2020

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#62.

Make sure you are using the project code style. Check the details here.

- Move Monitor_ReadMemory, Monitor_WriteMemory, Monitor_EraseMemory, Monitor_QueryConfiguration, Monitor_QueryConfiguration, Monitor_UpdateConfiguration, Monitor_CheckMemory, Monitor_MemoryMap, and Monitor_FlashSectorMap implementations to a common location.
- Remove unnecessary flags check on several commands.
- Remove weak attribute on several WP commands implementation.
@josesimoes josesimoes merged commit 71ff379 into nanoframework:develop Nov 24, 2020
@josesimoes josesimoes deleted the work-wp-commands branch December 7, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Platform: NXP Everything related specifically with FreeRTOS Platform: STM32 Everything related specifically with ChibiOS platform Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants