Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphics DisplayControl and fix method_lookup table #1817

Merged
merged 9 commits into from
Dec 22, 2020
Merged

Update graphics DisplayControl and fix method_lookup table #1817

merged 9 commits into from
Dec 22, 2020

Conversation

AdrianSoundy
Copy link
Member

Description

Sorted out issues and hard coded screen dimensions in Display control class.
Since last version the Graphic method_lookup was wrong so stopped everything running

Motivation and Context

-Fixes issues

How Has This Been Tested?

With separate test programs and primitive sample

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented Dec 22, 2020

Hi @AdrianSoundy,

🤔 All our issues are tracked in Home repo. If this PR addresses an issue that's mentioned there, please make sure it references it using the correct pattern: nanoFramework/Home#NNNN.

Automated fixes for code style.
@nfbot
Copy link
Member

nfbot commented Dec 22, 2020

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See https://github.com/AdrianSoundy/nf-interpreter/pull/21.

Make sure you are using the project code style. Check the details here.

…a-1184-4250-bf33-0d035c92d723' into ui-tests
@@ -5,7 +5,7 @@

//-----------------------------------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have the standard licensing header.

Not sure what changed this as it wasn't like this before.
@nfbot
Copy link
Member

nfbot commented Dec 22, 2020

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See https://github.com/AdrianSoundy/nf-interpreter/pull/22.

Make sure you are using the project code style. Check the details here.

AdrianSoundy and others added 3 commits December 22, 2020 23:24
@nfbot
Copy link
Member

nfbot commented Dec 22, 2020

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See https://github.com/AdrianSoundy/nf-interpreter/pull/23.

Make sure you are using the project code style. Check the details here.

…6-15d7-4b48-bced-8357b3969e90' into ui-tests
@nfbot
Copy link
Member

nfbot commented Dec 22, 2020

Hi @AdrianSoundy,

🤔 All our issues are tracked in Home repo. If this PR addresses an issue that's mentioned there, please make sure it references it using the correct pattern: nanoFramework/Home#NNNN.

@AdrianSoundy AdrianSoundy merged commit 8aa09a7 into nanoframework:develop Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants