-
-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes for RS485 mode #1826
Changes for RS485 mode #1826
Conversation
Automated fixes for code style.
@AdrianSoundy there are issues with the code style on the source files. Make sure you are using the project code style. Check the details here. |
…2-7cca-4fb0-90c1-e66b12312990' into serial-rs485
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Can you please add a check to the other platforms to throw an NOT IMPLEMENTED exception when the SerialMode is set to RS485? That will make it clear to developers trying to use this feature on platforms that don't support or don't have this feature available.
Give error if RS485 mode selected
Tested on 469 Discovery and give not implemented exception |
Automated fixes for code style.
@AdrianSoundy there are issues with the code style on the source files. Make sure you are using the project code style. Check the details here. |
…c-683e-4427-8017-6a58e21b0120' into serial-rs485
Description
Add RS485 for ESP32 only
Motivation and Context
How Has This Been Tested?
Simple test program to send data and check results on logic analyser
`
`
TX & RTS
RTS does seem to stay on a little longer than expected after last byte sent but that's done by ESP IDF
Types of changes
Checklist: