Multi Cast Delegate with Struct types cause CLR_E_WRONG_TYPE exception

[AdrianSoundy]

Description

MultiCast delegate for Structure value types( structs, DateTime, TimeSpan) causes a CLR_E_WRONG_TYPE error. Other types work ok. This looks like an edge case inherited from .NetMF.

Single Cast delegates work differently and don't have a problem.

This is due to the code trying to Unbox the valueType argument in CLR_RT_StackFrame::FixCall, but its doesn't need unboxing as its a structure type. The PerformUnboxing causes the error because it tests for valuetype to be boxed.

Adding an extra test for IsBoxed resolves issue.

Spent some time doing a delegate test program with various types , single and multi cast. Included test project with this PR

Motivation and Context

• Fixes Multicast Delegate Invocation causes exception under certain circumstance. Home#669

How Has This Been Tested?

Delegate test program (included)

Screenshots

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[nfbot]

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See https://github.com/AdrianSoundy/nf-interpreter/pull/28.

Make sure you are using the project code style. Check the details here.

[nfbot]

@AdrianSoundy there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See https://github.com/AdrianSoundy/nf-interpreter/pull/29.

Make sure you are using the project code style. Check the details here.

[AdrianSoundy]

MulticastDelegateTest.zip

[AdrianSoundy]

Tests for all types and arrays. Maybe be useful to update to test with generics

[josesimoes]

This test for the heapblock containing a boxed value seems to be all it takes to properly deal with this. Well done! 💯 👍🏻