Fixed ESP32 GPIO Uninitialize #1854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of solving issue #705 it was noticed that, if any INPUT pins are defined, the application raises an unhandled exception when entering deep sleep state. This change is to fix this problem. It was found that the way <<CPU_GPIO_Uninitialize>> is implemented, a linked list itteration fails after the current item in the linked list gets removed during the itteration. A better coding pattern is now used which allows removal of the item while itterating.
Automated fixes for code style.
|
@hbraasch there are issues with the code style on the source files. Make sure you are using the project code style. Check the details here. |
…7de-7b23-4abf-a9e7-7276b2c31254 Code style fixes for nanoframework/nf-interpreter PR#1854
josesimoes
added
the
Series: ESP32
josesimoes
approved these changes
Mar 11, 2021
josesimoes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The way CPU_GPIO_Uninitialize was implemented, a linked list itteration fails after the current item in the linked list gets removed during the itteration.
A better coding pattern, macro NANOCLR_FOREACH_NODE is now used which allows removal of the item while itterating.
Motivation and Context
As part of solving issue #705 it was noticed that, if any INPUT pins are defined, the application raises an unhandled exception when entering deep sleep state.
How Has This Been Tested?
Tested on a cloned build using the same test app using for Issue #705
Screenshots
Types of changes
Checklist: