Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement native support for new Network Information calls #1858

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Add implementation for GetIsNetworkAvailable.
  • Add implementation for IPGlobalProperties::GetIPAddress.
  • Add low level code in lwIP to support these.
  • Add stubs in TI SimpleLink to support these.
  • Update CMake accordingly.
  • Update System.Net assembly declaration.

Motivation and Context

How Has This Been Tested?

  • Network sample from samples repo.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Add implementation for GetIsNetworkAvailable.
- Add implementation for IPGlobalProperties::GetUnicastAddresses.
- Add low level code in lwIP to support these.
- Add stubs in TI SimpleLink to support these.
- Update CMake accordingly.
- Update System.Net assembly declaration.
@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Mar 18, 2021
@nfbot
Copy link
Member

nfbot commented Mar 18, 2021

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#71.

Make sure you are using the project code style. Check the details here.

Automated fixes for code style.
@josesimoes josesimoes merged commit 5f5bced into nanoframework:develop Mar 18, 2021
@josesimoes josesimoes deleted the work-system-net branch March 18, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants