Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework of WireProtocol #1884

Merged
merged 3 commits into from
Apr 19, 2021
Merged

Rework of WireProtocol #1884

merged 3 commits into from
Apr 19, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Simplification of WP Message: remove unnecessary parameter passing.
  • Improvement of message processing: now it's possible to actually find the header marker on an message
  • Significate refactor the WP Message moving vars inside when possible, rename several, simplification on several of the state machine states.
  • Simplification of receiver thread on targets: prepare reception is now called only once, process message is now the only call in the loop.
  • HAL interface calls now return bool.
  • Fix WP_ReceiveBytes to adjust to expected outcome and workflow of process message state machine.

Motivation and Context

  • Global improvement of WP processing and responsiveness.

How Has This Been Tested?

  • Debugger test app.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes
Rework of WireProtocol
6d747fc 
- Simplification of WP Message: remove unnecessary parameter passing.
- Improvement of message processing: now it's possible to actually find the header marker on an message
- Significate refactor the WP Message moving vars inside when possible, rename several, simplification on several of the state machine states.
- Simplification of receiver thread on targets: prepare reception is now called only once, process message is now the only call in the loop.
- HAL interface calls now return bool.
- Fix WP_ReceiveBytes to adjust to expected outcome and workflow of process message state machine.
@nfbot
Copy link
Member

nfbot commented Apr 19, 2021

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please review and merge the changes. See Eclo#79.

Make sure you are using the project code style. Check the details here.

nfbot and others added 2 commits April 19, 2021 12:44
@josesimoes josesimoes merged commit d5115e4 into nanoframework:develop Apr 19, 2021
@josesimoes josesimoes deleted the rework-wp branch April 19, 2021 13:29
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Apr 26, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)"
649582d 
This reverts commit d5115e4.
josesimoes added a commit that referenced this pull request Apr 26, 2021
@josesimoes
Revert "Rework of WireProtocol (#1884)" (#1897)
7d63995
josesimoes added a commit that referenced this pull request May 1, 2021
@josesimoes
Revert "Rework of WireProtocol (#1884)" (#1897)
7e82e46
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 8, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
d828608 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 21, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
8c3fda9 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jun 21, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
5e6df2d 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Jul 8, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
6b7cb11 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 3, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
a55cc11 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 5, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
2f4bbdb 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 6, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
9b91c96 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 6, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
effe0bd 
)
josesimoes added a commit that referenced this pull request Aug 12, 2021
@josesimoes
Revert "Rework of WireProtocol (#1884)" (#1897)
8c209e6
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 13, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
2083ec9 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 16, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
9276bb3 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 17, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
1f7d8f0 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 25, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
7b3b15d 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 9, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
838e448 
)
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 29, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
e97b325 
)
josesimoes added a commit that referenced this pull request Oct 1, 2021
@josesimoes
Revert "Rework of WireProtocol (#1884)" (#1897)
47a8ac4
josesimoes added a commit that referenced this pull request Oct 13, 2021
@josesimoes
Revert "Rework of WireProtocol (#1884)" (#1897)
ccfd7a1
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Dec 8, 2021
@josesimoes
Revert "Rework of WireProtocol (nanoframework#1884)" (nanoframework#1897
cfce3a6 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josesimoes @nfbot