Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct declaration of Windows.Storage #1903

Merged
merged 2 commits into from
May 6, 2021

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented May 6, 2021

Description

Motivation and Context

Something has changed with MDP that has caused an issue with the stub for Windows.Storage.
This fixes the immediate issue, but might be hiding something more sinister for other libs.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added the Type: bug label May 6, 2021
@josesimoes josesimoes added Type: dependencies Pull requests that update a dependency file(s) or version and removed Type: bug labels May 6, 2021
@josesimoes josesimoes enabled auto-merge (squash) May 6, 2021 20:19
@josesimoes josesimoes changed the title Correct issue with stub for windows.storage. Correct declaration of Windows.Storage May 6, 2021
@josesimoes josesimoes merged commit 848d3cf into develop May 6, 2021
@josesimoes josesimoes deleted the develop-windows-storage-checksum branch May 7, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: dependencies Pull requests that update a dependency file(s) or version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants