Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TimeoutException #1919

Merged
merged 8 commits into from
May 19, 2021
Merged

Adding TimeoutException #1919

merged 8 commits into from
May 19, 2021

Conversation

Ellerbach
Copy link
Member

@Ellerbach Ellerbach commented May 18, 2021

Adding TimeoutException. this exception was categorized as Exception. It is maintly used in Serial Ports which is coming as well as in some native API like SPI.

Description

Adding TimeoutException. this exception was categorized as Exception. It is maintly used in Serial Ports which is coming as well as in some native API like SPI.

Motivation and Context

  • Better handling and representation of TimeoutExpression
  • Prepare for System.IO.Ports

How Has This Been Tested?

  • build image, deployed image on an ESP32
  • tested with the added test, checked the output was correct and correct Exception raised

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot
Copy link
Member

nfbot commented May 18, 2021

@Ellerbach there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click #1920, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

Automated fixes for code style.
@josesimoes josesimoes enabled auto-merge (squash) May 19, 2021 10:53
@josesimoes josesimoes merged commit 85ecc02 into develop May 19, 2021
@josesimoes josesimoes deleted the develop-timeoutexception branch May 19, 2021 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants