Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing flag in CLR_DBG_Commands (#1949) #1949

Merged
merged 1 commit into from
Jun 9, 2021

Conversation

microhobby
Copy link
Contributor

@microhobby microhobby commented Jun 9, 2021

This fix an error when using src/CLR/Debugger/Debugger_minimal.cpp
that uses DEFINE_CMD2(TargetInfo), which resolve to
CLR_DBG_Commands::c_Monitor_TargetInfo

Signed-off-by: Matheus Castello matheus@castello.eng.br

Description

This fix an error when using src/CLR/Debugger/Debugger_minimal.cpp
that uses DEFINE_CMD2(TargetInfo), which resolve to
CLR_DBG_Commands::c_Monitor_TargetInfo

Motivation and Context

How Has This Been Tested?

Building using Debugger_minimal.cpp

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

(For me https://github.com/nanoframework/.github/blob/main/CONTRIBUTING.md is resulting in a 404 error page)

This fix an error when using src/CLR/Debugger/Debugger_minimal.cpp
that uses `DEFINE_CMD2(TargetInfo),` which resolve to
CLR_DBG_Commands::c_Monitor_TargetInfo

Signed-off-by: Matheus Castello <matheus@castello.eng.br>
@nfbot nfbot added the Type: bug label Jun 9, 2021
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Jun 9, 2021
@josesimoes josesimoes merged commit 64f3c47 into nanoframework:develop Jun 9, 2021
@josesimoes josesimoes changed the title nanoCLR_Debugging: Add c_Monitor_TargetInfo to CLR_DBG_Commands Add missing flag in CLR_DBG_Commands (#1949) Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants