Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unbox.any for GUID type #1956

Merged
merged 2 commits into from
Jun 21, 2021
Merged

Fix unbox.any for GUID type #1956

merged 2 commits into from
Jun 21, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Add GUID to WellKnownTypes.
  • Add code to PerformUnboxing to check for valid GUID unboxing.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

- Add GUID to WellKnownTypes.
- Add code to PerformUnboxing to check for valid GUID unboxing.
@nfbot
Copy link
Member

nfbot commented Jun 21, 2021

@josesimoes there are issues with the code style on the source files.
A PR was submitted with the code style fixes. Please click Eclo#87, review the changes if you want and merge it.

Make sure to follow the project code style. Check the details here on how it works and the tools required to help you with that.

Automated fixes for code style.
@josesimoes josesimoes merged commit 9944738 into nanoframework:develop Jun 21, 2021
@josesimoes josesimoes deleted the fix-757 branch June 21, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit test for invalid cast of Guid passes
2 participants