Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Assembly.Load with static constructors and fields #1973

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Rework code so that thread execution only continues after the static constructors are executed.
  • Add PushValueU4 to CLR_RT_StackFrame.

Motivation and Context

How Has This Been Tested?

  • Test project from the issue.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nfbot nfbot added the Type: bug label Jul 5, 2021
- Rework code so that thread execution only continues after the static constructors are executed.
- Add PushValueU4 to CLR_RT_StackFrame.
@josesimoes josesimoes merged commit 6fcdd98 into nanoframework:develop Jul 5, 2021
@josesimoes josesimoes deleted the fix-733 branch July 5, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static fields and static constructors aren't initialized/called when assembly is loaded in code
2 participants