Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new compiler warnings #2011

Merged
merged 1 commit into from
Aug 13, 2021
Merged

Conversation

josesimoes
Copy link
Member

Description

  • Add -Wshadow -Wimplicit-fallthrough compilers warnings.
  • Various code fixes following these.

Motivation and Context

  • Improve code quality (already paying of as several issues were spotted and fixed).

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes added the Area: Common libs Everything related with common libraries label Aug 13, 2021
- Add -Wshadow -Wimplicit-fallthrough compilers warnings.
- Various code fixes following these.
@josesimoes josesimoes merged commit aeb04bb into nanoframework:develop Aug 13, 2021
@josesimoes josesimoes deleted the add-warning branch August 13, 2021 10:01
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 13, 2021
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 16, 2021
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 17, 2021
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 25, 2021
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 9, 2021
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 29, 2021
josesimoes added a commit that referenced this pull request Oct 1, 2021
josesimoes added a commit that referenced this pull request Oct 13, 2021
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Common libs Everything related with common libraries Area: Config-and-Build Type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants