Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WireProtocol Receive processing #2012

Merged
merged 1 commit into from
Aug 16, 2021
Merged

Fix WireProtocol Receive processing #2012

merged 1 commit into from
Aug 16, 2021

Conversation

josesimoes
Copy link
Member

Description

  • Update declaration of WP_ReceiveBytes to pass position argument by reference and remove return.
  • Update code and declarations on all platform implementations.
  • Remove unnused globals in WP Message.
  • Fix code in ReceiveState_ReadingHeader state.
  • Add cast to ReceiveState enum to make sure of correct type.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (work on Unit Tests, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@josesimoes josesimoes added Area: Common libs Everything related with common libraries Series: ESP32 Everything related specifically with ESP32 series targets Series: NXP i6 Everything related specifically with NXP targets Series: STM32xx Everything related specifically with STM32 targets Platform: STM32 Everything related specifically with ChibiOS platform Platform: NXP Everything related specifically with FreeRTOS Platform: ESP32 Everything related specifically with ESP32 platform and removed Series: STM32xx Everything related specifically with STM32 targets Series: ESP32 Everything related specifically with ESP32 series targets Series: NXP i6 Everything related specifically with NXP targets labels Aug 16, 2021
@josesimoes josesimoes force-pushed the fix-wp branch 2 times, most recently from e28718d to 4b6bb1e Compare August 16, 2021 17:12
@josesimoes
Fix WireProtocol Receive processing
3f1c359 
- Update declaration of WP_ReceiveBytes to pass position argument by reference and remove return.
- Update code and declarations on all platform implementations.
- Remove unnused globals in WP Message.
- Fix code in ReceiveState_ReadingHeader state.
- Add cast to ReceiveState enum to make sure of correct type.
@josesimoes josesimoes merged commit cc5c4c7 into nanoframework:develop Aug 16, 2021
@josesimoes josesimoes deleted the fix-wp branch August 16, 2021 17:33
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 16, 2021
@josesimoes
Update implementation of WP_ReceiveBytes
a29a4b4 
- Following nanoframework#2012.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 17, 2021
@josesimoes
Update implementation of WP_ReceiveBytes
74bc978 
- Following nanoframework#2012.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Aug 25, 2021
@josesimoes
Update implementation of WP_ReceiveBytes
9d68666 
- Following nanoframework#2012.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 9, 2021
@josesimoes
Update implementation of WP_ReceiveBytes
70f3ea2 
- Following nanoframework#2012.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Sep 29, 2021
@josesimoes
Update implementation of WP_ReceiveBytes
8900443 
- Following nanoframework#2012.
josesimoes added a commit that referenced this pull request Oct 1, 2021
@josesimoes
Update implementation of WP_ReceiveBytes
1459800 
- Following #2012.
josesimoes added a commit that referenced this pull request Oct 13, 2021
@josesimoes
Update implementation of WP_ReceiveBytes
b783513 
- Following #2012.
josesimoes added a commit to Eclo/nf-interpreter that referenced this pull request Dec 8, 2021
@josesimoes
Update implementation of WP_ReceiveBytes
9e0c273 
- Following nanoframework#2012.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Common libs Everything related with common libraries Platform: ESP32 Everything related specifically with ESP32 platform Platform: NXP Everything related specifically with FreeRTOS Platform: STM32 Everything related specifically with ChibiOS platform Type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

stm32f091 debug doesn't work
2 participants
@josesimoes @nfbot